[PATCH] D79971: [X86] Rewrite how X86PartialReduction find candidates to consider optimizing.
    Sanjay Patel via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sun May 31 07:58:20 PDT 2020
    
    
  
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM - probably still want to make sure there's good enough negative test coverage, but that is true even before this patch.
================
Comment at: llvm/lib/Target/X86/X86PartialReduction.cpp:406
+
+        // If there is additional use, make sure its an unvisited phi that gets
+        // us back to this node.
----------------
spatel wrote:
> its -> it is
grammar nit still here
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79971/new/
https://reviews.llvm.org/D79971
    
    
More information about the llvm-commits
mailing list