[PATCH] D80885: [VectorCombine] scalarizeBinop - support an all-constant src vector operand

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 31 06:54:51 PDT 2020


spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:375
+
+  // For constant cases, extract the scalar element, this should constant fold.
+  if (!V0)
----------------
Should assert or give up if the Builder result is not a constant. I don't think there's any danger from constant expressions or missing constant folding, but fuzzers may find a way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80885/new/

https://reviews.llvm.org/D80885





More information about the llvm-commits mailing list