[PATCH] D80875: [ValueTracking] Branch on poison is UB, branch cond is non-poison.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 31 05:50:56 PDT 2020


fhahn added a comment.

In D80875#2065190 <https://reviews.llvm.org/D80875#2065190>, @efriedma wrote:

> Actually, thinking about it a bit more, I'm not completely comfortable with landing this yet.  We still have a few known issues with IR transforms that don't correctly freeze branch conditions, and I'm afraid the interaction here might expose them as miscompiles.


Sounds good to me! I've filed https://bugs.llvm.org/show_bug.cgi?id=46144 to collect/keep information of the passes that need fixing. I guess it's fine to wait with landing this patch until most issues have been resolved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80875/new/

https://reviews.llvm.org/D80875





More information about the llvm-commits mailing list