[PATCH] D80872: [ELF] Set DF_1_PIE for -pie

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 30 13:14:47 PDT 2020


emaste added a comment.

This LGTM.
I'm now adding support in FreeBSD, e.g.  https://reviews.freebsd.org/rS361657



================
Comment at: lld/ELF/SyntheticSections.cpp:1320-1321
     dtFlags1 |= DF_1_NOOPEN;
+  if (config->pie)
+    dtFlags1 |= DF_1_PIE;
   if (config->zNow) {
----------------
MaskRay wrote:
> emaste wrote:
> > should this be in alpha order?
> For options which only affect `DF_1_*`, this order is already alphabetical.
Ah, indeed, order of flag bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80872/new/

https://reviews.llvm.org/D80872





More information about the llvm-commits mailing list