[PATCH] D80604: [MachineCombiner] add a hook to allow some extension for resource length - NFC

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 30 10:03:10 PDT 2020


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM with minor fix.

These might also be interesting FMA discussions/examples to look at:
D80801 <https://reviews.llvm.org/D80801>
D18751 <https://reviews.llvm.org/D18751>



================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:1099
+  /// The limit on resource length extension we accept in MachineCombiner Pass.
+  virtual int16_t getExtendResourceLenLimit() const { return 0; }
+
----------------
Is there a reason to make this int16_t? If yes, it should be specified in the code comment. If not, just use plain 'int' or 'unsigned'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80604/new/

https://reviews.llvm.org/D80604





More information about the llvm-commits mailing list