[PATCH] D79391: [DSE] Remove noop stores in MSSA.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 30 04:44:42 PDT 2020


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

This should only remove stores which we couldn't kill other stores, as the load would block the store killing any other stores.

In D79391#2064706 <https://reviews.llvm.org/D79391#2064706>, @zoecarver wrote:

>




> 
> 
>> Hm I think cmake might not pick up CXXFLAGS...
> 
> suggested and made sure to export `EnableMemorySSA=1` (and even tried a clean build of both)

Oh right, I meant flipping the `cl::init` value of the variable https://github.com/llvm/llvm-project/blob/master/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp#L100 and rebuilding ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79391/new/

https://reviews.llvm.org/D79391





More information about the llvm-commits mailing list