[PATCH] D80203: [ObjectYAML][DWARF] Add DWARF entry in ELFYAML.

Fri May 29 23:57:18 PDT 2020

Higuoxing marked 3 inline comments as done.
Higuoxing added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-str.yaml:145
+    Offset:       0x00000050         # 0x40 for the first section.
+    Size:         6                  # Set the "Size" so that we can reuse the check tag "OVERRIEDDEN"
+
----------------
jhenderson wrote:
> jhenderson wrote:
> > There's a typo: OVERRIEDDEN -> OVERRIDDEN
> It looks like this comment wasn't addressed?
Should be fixed in D80802. Sorry I didn't notice it here.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-str.yaml:196
+# RUN: yaml2obj --docnum=9 %s -o %t9.o
+# RUN: llvm-readelf -S %t9.o | FileCheck %s --check-prefix=DYNAMIC-EMPTY
+
----------------
jhenderson wrote:
> I'd avoid using -EMPTY in your suffix name, since -EMPTY is a valid FileCheck suffix. Probably it's okay just to call these cases DYNAMIC1, DYNAMIC2 etc.
The `check-prefix` is changed to `DYN-SHDR` in my commit. Sorry, I didn't submit a updated-diff before my commit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80203/new/

https://reviews.llvm.org/D80203