[PATCH] D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 21:14:40 PDT 2020


int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/Writer.cpp:417-418
     addr = alignTo(addr, section->align);
-    // We must align the file offsets too to avoid misaligned writes of
-    // structs.
     fileOff = alignTo(fileOff, section->align);
----------------
removed this comment since it's no longer relevant, though I'm still keeping the `alignTo` call since I believe ld64 does something similar


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80414/new/

https://reviews.llvm.org/D80414





More information about the llvm-commits mailing list