[PATCH] D79385: NFC: Simplify O1 pass pipeline construction.

[Eric Christopher via Phabricator via llvm-commits]

echristo marked an inline comment as done.
echristo added a comment.

Thanks. I'll go ahead and commit after the loop unrolling optimization patch.



================
Comment at: llvm/lib/Passes/PassBuilder.cpp:435
+
+  // TODO: Investigate the cost/benefit of tail call elimination on debugging.
+  FPM.addPass(SimplifyCFGPass());
----------------
chandlerc wrote:
> chandlerc wrote:
> > Mapbe pull to the function comment? Doesn't seem especially relevant here given the other `SimplifyCFGPass` runs.
> FWIW, I think this is the one I'd go ahead and do in this patch -- it seems specifically relevant to the extraction of the pipeline.
Yeah. That comment is just in the wrong place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79385/new/

https://reviews.llvm.org/D79385