[PATCH] D80842: [mlir] Add verify method to adaptor

[Aart Bik via Phabricator via llvm-commits]

aartbik added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp:324
 
+// Populate the format context for substitutions of attributes, operands and
+// results.
----------------
.. format context 'ctx'  for
(since this is an output var, good to document)


================
Comment at: mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp:333
+                 formatv("{0}(\"{1}\")", attrGet, namedAttr.name));
+  for (int i = 0, e = op.getNumOperands(); i < e; ++i) {
+    auto &value = op.getOperand(i);
----------------
nit: here and below, "unsigned int" seems slightly more idiomatic


================
Comment at: mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp:1905
 
+  // Add verification function.
+  void addVerification();
----------------
This is very minimum documentation for such an important new method....


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80842/new/

https://reviews.llvm.org/D80842