[PATCH] D79964: Update 'git push' command in GettingStarted guide

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 18:02:37 PDT 2020


mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/docs/Phabricator.rst:218
   ninja check-$whatever # Rerun the appropriate tests if needed.
-  git push
+  git push origin HEAD:master
 
----------------
tstellar wrote:
> I would even take this a step further and replace origin with the full repo name e.g.
> 
> git push https://github.com/llvm/llvm-project.git HEAD:master
> 
> I think the documentation should give instructions that are guaranteed to work regardless of the user's configuration.
> I think the documentation should give instructions that are guaranteed to work regardless of the user's configuration.

Documentation for developer can be skewed towards providing instruction in a usable form: I'm not gonna type the complete URL!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79964/new/

https://reviews.llvm.org/D79964





More information about the llvm-commits mailing list