[PATCH] D80853: AMDGPU: Add setTruncStoreAction for vector i64 types made legal recently

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 16:57:34 PDT 2020


cfang created this revision.
cfang added reviewers: arsenm, rampitec.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

This fixes instruction selection asserts encountered in the conformance tests.


https://reviews.llvm.org/D80853

Files:
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AMDGPU/trunc-store-i64.ll


Index: llvm/test/CodeGen/AMDGPU/trunc-store-i64.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/AMDGPU/trunc-store-i64.ll
@@ -0,0 +1,50 @@
+; RUN: llc -march=amdgcn -mcpu=gfx906 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
+
+; GCN-LABEL: {{^}}trunc_store_v4i64_v4i8:
+; GCN: global_store_dword v{{\[[0-9]:[0-9]+\]}}, v{{[0-9]+}}, off
+define amdgpu_kernel void @trunc_store_v4i64_v4i8(< 4 x i8> addrspace(1)* %out, <4 x i64> %in) {
+entry:
+  %trunc = trunc <4 x i64> %in to < 4 x i8>
+  store <4 x i8> %trunc, <4 x i8> addrspace(1)* %out
+  ret void
+}
+
+; GCN-LABEL: {{^}}trunc_store_v8i64_v8i8:
+; GCN: global_store_dwordx2 v{{\[[0-9]:[0-9]+\]}}, v{{\[[0-9]:[0-9]+\]}}, off
+define amdgpu_kernel void @trunc_store_v8i64_v8i8(< 8 x i8> addrspace(1)* %out, <8 x i64> %in) {
+entry:
+  %trunc = trunc <8 x i64> %in to < 8 x i8>
+  store <8 x i8> %trunc, <8 x i8> addrspace(1)* %out
+  ret void
+}
+
+; GCN-LABEL: {{^}}trunc_store_v8i64_v8i16:
+; GCN: global_store_dwordx4 v{{\[[0-9]:[0-9]+\]}}, v{{\[[0-9]:[0-9]+\]}}, off
+define amdgpu_kernel void @trunc_store_v8i64_v8i16(< 8 x i16> addrspace(1)* %out, <8 x i64> %in) {
+entry:
+  %trunc = trunc <8 x i64> %in to < 8 x i16>
+  store <8 x i16> %trunc, <8 x i16> addrspace(1)* %out
+  ret void
+}
+
+; GCN-LABEL: {{^}}trunc_store_v8i64_v8i32:
+; GCN: global_store_dwordx4 v{{\[[0-9]:[0-9]+\]}}, v{{\[[0-9]:[0-9]+\]}}, off offset:16
+; GCN: global_store_dwordx4 v{{\[[0-9]:[0-9]+\]}}, v{{\[[0-9]:[0-9]+\]}}, off
+define amdgpu_kernel void @trunc_store_v8i64_v8i32(< 8 x i32> addrspace(1)* %out, <8 x i64> %in) {
+entry:
+  %trunc = trunc <8 x i64> %in to <8 x i32>
+  store <8 x i32> %trunc, <8 x i32> addrspace(1)* %out
+  ret void
+}
+
+; GCN-LABEL: {{^}}trunc_store_v16i64_v16i32:
+; GCN: global_store_dwordx4 v{{\[[0-9]:[0-9]+\]}}, v{{\[[0-9]:[0-9]+\]}}, off offset:48
+; GCN: global_store_dwordx4 v{{\[[0-9]:[0-9]+\]}}, v{{\[[0-9]:[0-9]+\]}}, off offset:32
+; GCN: global_store_dwordx4 v{{\[[0-9]:[0-9]+\]}}, v{{\[[0-9]:[0-9]+\]}}, off offset:16
+; GCN: global_store_dwordx4 v{{\[[0-9]:[0-9]+\]}}, v{{\[[0-9]:[0-9]+\]}}, off
+define amdgpu_kernel void @trunc_store_v16i64_v16i32(< 16 x i32> addrspace(1)* %out, <16 x i64> %in) {
+entry:
+  %trunc = trunc <16 x i64> %in to <16 x i32>
+  store <16 x i32> %trunc, <16 x i32> addrspace(1)* %out
+  ret void
+}
Index: llvm/lib/Target/AMDGPU/SIISelLowering.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -220,6 +220,12 @@
   setTruncStoreAction(MVT::v16i16, MVT::v16i8, Expand);
   setTruncStoreAction(MVT::v32i16, MVT::v32i8, Expand);
 
+  setTruncStoreAction(MVT::v4i64, MVT::v4i8, Expand);
+  setTruncStoreAction(MVT::v8i64, MVT::v8i8, Expand);
+  setTruncStoreAction(MVT::v8i64, MVT::v8i16, Expand);
+  setTruncStoreAction(MVT::v8i64, MVT::v8i32, Expand);
+  setTruncStoreAction(MVT::v16i64, MVT::v16i32, Expand);
+
   setOperationAction(ISD::GlobalAddress, MVT::i32, Custom);
   setOperationAction(ISD::GlobalAddress, MVT::i64, Custom);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80853.267414.patch
Type: text/x-patch
Size: 3139 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200529/9c44ae87/attachment.bin>


More information about the llvm-commits mailing list