[PATCH] D80826: [CodeGen][SVE] Replace deprecated calls in getCopyFromPartsVector()

Henry Kao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 16:25:08 PDT 2020


hkao13 marked an inline comment as done.
hkao13 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:487
   EVT ValueSVT = ValueVT.getVectorElementType();
-  if (ValueVT.getVectorNumElements() == 1 && ValueSVT != PartEVT) {
+  if (ValueVT.getVectorElementCount().Min == 1 && ValueSVT != PartEVT) {
     if (ValueSVT.getSizeInBits() == PartEVT.getSizeInBits())
----------------
efriedma wrote:
> There are significant functional implications here, related to the type breakdown stuff Sander is looking at... a v1i8 is actually one element, an nxv1i8 is not.  This needs some real design discussion and testing.
I reverted this back to getVectorNumElements(), we can revisit this part in a later patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80826/new/

https://reviews.llvm.org/D80826





More information about the llvm-commits mailing list