[PATCH] D80826: [CodeGen][SVE] Replace deprecated calls in getCopyFromPartsVector()

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/include/llvm/Support/TypeSize.h:53
+  bool operator>(const ElementCount& RHS) const {
+    return Min > RHS.Min && Scalable == RHS.Scalable;
+  }
----------------
hkao13 wrote:
> efriedma wrote:
> > These operators are a little dubious; it's possible for both A<B and A>=B to be false, which goes against mathematical intuition.
> Thanks for the review. Strict weak ordering is implemented -- (A < B) and (A >=B) can both be false as long as (A > B) is true.  Is there a case where scalable and unscalable widths would be compared? If so then I can remove the LHS and RHS scalable comparisons from the operator overloads.
I think I'd prefer to just write out the operation in the users for now, until we have some practical experience with what patterns we end up using in practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80826/new/

https://reviews.llvm.org/D80826