[PATCH] D80711: Utility to dump .dot representation of SelectionDAG without firing viewer

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp:178-179
+#else
+  errs() << "SelectionDAG::DumpDotGraph is only available in debug builds or "
+         << "when LLVM_ENABLE_DUMP is ON.\n";
+#endif // NDEBUG
----------------
I think having anything here defeats the point of having a compile time way to remove the function. The function should not be present in the build at all without LLVM_ENABLE_DUMP


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80711/new/

https://reviews.llvm.org/D80711