[PATCH] D80826: [CodeGen][SVE] Replace deprecated calls in getCopyFromPartsVector()
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 29 12:35:03 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:451
- assert(PartEVT.getVectorNumElements() == ValueVT.getVectorNumElements() &&
+ assert(PartEVT.getVectorElementCount() == ValueVT.getVectorElementCount() &&
"Cannot handle this kind of promotion");
----------------
Changing the assertions here is fine.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:487
EVT ValueSVT = ValueVT.getVectorElementType();
- if (ValueVT.getVectorNumElements() == 1 && ValueSVT != PartEVT) {
+ if (ValueVT.getVectorElementCount().Min == 1 && ValueSVT != PartEVT) {
if (ValueSVT.getSizeInBits() == PartEVT.getSizeInBits())
----------------
There are significant functional implications here, related to the type breakdown stuff Sander is looking at... a v1i8 is actually one element, an nxv1i8 is not. This needs some real design discussion and testing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80826/new/
https://reviews.llvm.org/D80826
More information about the llvm-commits
mailing list