[PATCH] D80797: [DebugInfo] Check for errors when reading data for extended opcode

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h:74
+                               Error *Err = nullptr) const {
+    return getRelocatedValue(getAddressSize(), Off, SecIx, Err);
   }
----------------
I assume this never turns an error into a success?


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:877
       default:
-        if (OS)
+        if (!Err && OS)
           *OS << format("Unrecognized extended op 0x%02.02" PRIx8, SubOpcode)
----------------
This seems oddly stricter than before. Is the `!Err` condition necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80797/new/

https://reviews.llvm.org/D80797