[PATCH] D80684: [LiveDebugValues] Speed up removeEntryValue, NFC

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1362
+             VL.Kind == VarLoc::SpillLocKind && "Broken VarLocSet?");
+      if (VL.Loc.SpillLocation == *Loc)
+        LLVM_DEBUG(dbgs() << "Restoring Register " << printReg(Reg, TRI) << '('
----------------
aprantl wrote:
> ```
> if (VL.Loc.SpillLocation != *Loc)
>   // Comment explains why no pair is inserted...
>   continue;
> LLVM_DEBUG(dbgs() << "Restoring Register " ...
> ```
did this get marked as done by accident?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:477
     /// within Loc2Vars.
     std::map<VarLoc, uint32_t> Var2Index;
 
----------------
Side-note: does this get more readable if we introduce a typedef for uint32_t here, such a `VarLocIndex`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80684/new/

https://reviews.llvm.org/D80684