[PATCH] D80819: [DebugInfo][DAG] Don't reuse debug location on COPY if width changes.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a subscriber: debug-info.
vsk added a comment.

Thanks for this! The discussion on the bugzilla PR covers some alternative ways to tackle this, which I won’t rehash here. I think it's reasonable to shoot for a narrow bugfix first.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:627
         // Otherwise this is another use or second copy use.
         CopyUseMI = nullptr; break;
       }
----------------
I missed this earlier, but: with this change, if the first copy use fails the width check, we'd emit a debug value if there’s a second copy use of the register.

A narrow fix might be to move the width check to line 629, where we check whether CopyUseMI has been set and emit a debug value if so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80819/new/

https://reviews.llvm.org/D80819