[PATCH] D80663: [LangRef] Fix description of shape args for matrix.multiply.

Braedy Kuzma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 10:53:51 PDT 2020


braedy added a comment.

My concern using rows/columns in any of the argument names is that one of the dimensions changes from rows to columns, but you're right that perhaps outer isn't particularly descriptive enough and would require reading the overview instead of being able to understand it from just the signature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80663/new/

https://reviews.llvm.org/D80663





More information about the llvm-commits mailing list