[PATCH] D80618: Extend InvokeInst !prof branch_weights metadata to unwind branches

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi added inline comments.


================
Comment at: llvm/include/llvm/IR/Instruction.h:337
+  /// CallBase to this CallBase.
+  bool copyProfMetadata(const Instruction &SrcCB);
 
----------------
Can this function move to the CallBase class as it seems it's already specific to CallBase and all the existing call sites call on CallBase.


================
Comment at: llvm/lib/IR/Verifier.cpp:4173
+      Assert(MD->getNumOperands() == 2 || MD->getNumOperands() == 3,
+             "Wrong number of InvokeInst operands", MD);
+    else
----------------
"Wrong number of InvokeInst //branch_weights// operands" to be clearer?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80618/new/

https://reviews.llvm.org/D80618