[PATCH] D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D79963#2063120 <https://reviews.llvm.org/D79963#2063120>, @jroelofs wrote:

> In D79963#2062377 <https://reviews.llvm.org/D79963#2062377>, @jhenderson wrote:
>
> > There's probably not much risk of false negatives with that, but I don't know for sure.
>
>
> I haven't seen any `CHECK`s with missing colons where the comment marker was doubled up. I'd have to verify, but I also suspect that there are very few if any existing `CHECK:`s with doubled up comment markers.


This is basically my feeling (https://reviews.llvm.org/D79963#2051242). `;; CHECK` `@@ CHECK` `## CHECK` `/// CHECK` => the false positive rate will be pretty low.
FileCheck does not need to understand the file format (assembly, textual format LLVM IR, BCPL, ...). As long as any of `@@ ` `## ` `/// ` (maybe others) is seen, suppress the diagnostic.

Repeating the comment marker has been very common in LLVM binary utilities and LLD, and used somewhere in MC. It is much less common in CodeGen/Transforms/etc, but hope it is easier for people to accept than `; COM: `


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79963/new/

https://reviews.llvm.org/D79963