[PATCH] D80767: GlobalISel: fix CombinerHelper::matchEqualDefs()

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/postlegalizercombiner-select.mir:16
+    %0:_(s32), %1:_(s32) = G_UNMERGE_VALUES undef %2:_(<2 x s32>)
+    %3:_(s32) = G_SELECT undef %4:_(s1), %0:_, %1:_
+    $vgpr0 = COPY %3
----------------
I would prefer to use an explicit G_IMPLICIT_DEF rather than relying on an undef operand. I've been thinking undef operands should be a verifier error for SSA MIR


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80767/new/

https://reviews.llvm.org/D80767