[PATCH] D80512: [MC] Changes to help improve target specific symbol disassembly

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 07:34:29 PDT 2020


jhenderson added a comment.

In D80512#2062908 <https://reviews.llvm.org/D80512#2062908>, @rochauha wrote:

> @jhenderson, following was your previous comment on line 1399
>
>   > If you're going to modify this line, please also add the missing full stop and "skip" -> "Skip". Seems like it's unrelated to this patch.
>   
>
> So I modified the line when making revisions to the commit.


Right, but the modification prior to my comment there was just to remove a space in the comment. I said "if you are going to modify this line", but on closer look, I'm not sure why you wanted to modify the line in the first place, hence my question.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80512/new/

https://reviews.llvm.org/D80512





More information about the llvm-commits mailing list