[PATCH] D78865: [DWARF5] Replace emission of strp with stx forms in debug_macro section

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 06:29:17 PDT 2020


SouraVX added a comment.

In D78865#2062789 <https://reviews.llvm.org/D78865#2062789>, @ikudrin wrote:

> What are the benefits of using STRX code in the non-DWO case?


I think having one form in both cases (`split` and `non-split`) simplifies the emission logic greatly.  Otherwise we may have to carve out conditional emission that would be hard to maintain and extend. 
Please share your opinion on this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78865/new/

https://reviews.llvm.org/D78865





More information about the llvm-commits mailing list