[PATCH] D80707: [legacyPM] Do not compute preserved analysis if there's no local change

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 05:56:45 PDT 2020


foad added a comment.

> This makes me think that some passes are possibly not reporting changes correctly.

That would be my worry. As far as I know the boolean "changed" flag returned by runOn functions isn't really used for anything, and there is no verification to catch passes returning false when they actually did change something.

Perhaps if a pass returns false we should verify all analyses, rather than just the ones that the pass claims to preserve?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80707/new/

https://reviews.llvm.org/D80707





More information about the llvm-commits mailing list