[PATCH] D80728: [mlir][Linalg][Vector] Add forwarding patterns between linalg.copy and vector.transfer
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 29 05:23:53 PDT 2020
nicolasvasilache marked 7 inline comments as done.
nicolasvasilache added inline comments.
================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp:106
+ StringRef dbgPref = "\n[" DEBUG_TYPE "]: ";
+ (void)dbgPref;
----------------
ftynse wrote:
> I wonder if we want to write some macro wrapper along the lines of
>
> ```
> #ifdef DEBUG_TYPE
> #define DBGS() \
> (dbgs() << '[' << DEBUG_TYPE << "] ")
> #else
> #define DBGS() \
> (dbgs())
> #endif
> ```
>
> and propose it for LLVM.
It hasn't bugged me enough to go and do it but it would make sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80728/new/
https://reviews.llvm.org/D80728
More information about the llvm-commits
mailing list