[PATCH] D80442: [runtimes] Pass COMPILER_RT* through to runtime build

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 03:13:34 PDT 2020


russell.gallop abandoned this revision.
russell.gallop added a comment.

In D80442#2061115 <https://reviews.llvm.org/D80442#2061115>, @phosek wrote:

> This needs be done on a per-target basis, not globally (e.g. you may want to use `COMPILER_RT_BUILD_SANITIZERS=OFF` for target1 but not target2). Have you tried setting `RUNTIMES_${target}_COMPILER_RT_BUILD_SANITIZERS=OFF`? This should be already supported, see for example https://github.com/llvm/llvm-project/blob/master/clang/cmake/caches/Fuchsia-stage2.cmake#L100


Thanks, that works, and looks better so I'll close this review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80442/new/

https://reviews.llvm.org/D80442





More information about the llvm-commits mailing list