[PATCH] D80778: [SelectionDAGBuilder][WebAssembly] Omit range checks on jump tables

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 02:41:06 PDT 2020


hans added a comment.

Before digging into the code, would it be impractical to fold the range check into the br_table instruction in the wasm backend instead, "sniffing out the guard" and replacing it as suggested by that comment in WebAssemblyISelLowering.cpp?

Because I'm a little bit worried about this ipushing complexity up to the general switch lowering mechanism, for example breaking the invariant that jump tables have a size that matches their corresponding case range.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80778/new/

https://reviews.llvm.org/D80778





More information about the llvm-commits mailing list