[PATCH] D79391: [DSE] Remove noop stores in MSSA.

Thu May 28 20:51:23 PDT 2020

zoecarver marked an inline comment as done.
zoecarver added inline comments.

================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/simple.ll:34
 ;
-  %g_value = load i32, i32* %g_addr, align 4
   store i32 -1, i32* @g, align 4
----------------
fhahn wrote:
> Is there a reason for this change in the source (and some of the ones below)? I think we should keep the existing tests as is and add additional cases as required.
The load and store here would be removed. I wasn't sure if the noop store was inadvertent and wanted to keep the test as similar as possible to what I thought it was testing (that neither store is removed). If you'd rather I can remove the changes and update the `CHECK` comments instead. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79391/new/

https://reviews.llvm.org/D79391