[PATCH] D80028: [AArch64] Support expression results as immediate values in mov
Jian Cai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 28 18:43:34 PDT 2020
jcai19 added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:979
+ }
+ return !Shift && E;
}
----------------
efriedma wrote:
> E can't be null here?
>
> Maybe worth briefly explaining here what this allows.
the function would have returned at its begining if E is null. Comment added.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80028/new/
https://reviews.llvm.org/D80028
More information about the llvm-commits
mailing list