[PATCH] D80497: Make mlir::Value's bool conversion operator explicit

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 18:11:20 PDT 2020


MaskRay added a comment.

In D80497#2061854 <https://reviews.llvm.org/D80497#2061854>, @dblaikie wrote:

> I believe @MaskRay automated this for himself in some way - I can't find the thread right now, but I think he created some fragment of javascript using a browser trigger that automatically inserts a comment for him when approving patches - perhaps he can let you know how he managed it/you can use that.


Perhaps I should enrich the sentence set.

  // ==UserScript==
  // @name         reviews.llvm.org: add comment "LGTM" when accepting
  // @namespace    http://tampermonkey.net/
  // @version      0.1
  // @description  try to take over the world!
  // @author       You
  // @match        https://reviews.llvm.org/*
  // @grant        none
  // ==/UserScript==
  
  (function() {
    'use strict';
    const select = document.querySelector('.aphront-form-input > select')
    if (select)
      select.onchange = function() {
        const accept = select.querySelector('option[value=accept]')
        if (accept && accept.disabled) {
          const comment = document.querySelector('.remarkup-assist-textarea')
          if (comment && comment.value.length == 0) {
            const words = ['LGTM.', 'Thanks!', 'Looks great!']
            comment.value = words[~~(Math.random()*words.length)]+' '
            comment.focus()
          }
        }
      }
  })();


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80497/new/

https://reviews.llvm.org/D80497





More information about the llvm-commits mailing list