[PATCH] D80677: [lld-macho] Handle framework search path, alongside library search path

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:420-422
+  bool isOSDarwin = Triple(sys::getProcessTriple()).isOSDarwin();
+  config->librarySearchPaths = getLibrarySearchPaths(args, isOSDarwin);
+  config->frameworkSearchPaths = getFrameworkSearchPaths(args, isOSDarwin);
----------------
this seems reasonable to me (and it looks like lld-ELF has `isOS` checks too) but cc @MaskRay @ruiu just in case


================
Comment at: lld/MachO/Driver.cpp:428
+    message("Library search paths:" +
+            std::string(config->librarySearchPaths.size() ? "\n\t" : "") +
+            llvm::join(config->librarySearchPaths, "\n\t"));
----------------
would `StringRef` work here instead of `std::string`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80677/new/

https://reviews.llvm.org/D80677