[PATCH] D80765: [lld] Handle bitcode comdat groups separately to deduplicate thinlto comdat sections
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 28 17:38:26 PDT 2020
sbc100 added a comment.
Would you mind making the equivalent changes to lld/wasm?
And a test?
================
Comment at: lld/ELF/InputFiles.cpp:393
-template <class ELFT> void ObjFile<ELFT>::parse(bool ignoreComdats) {
+template <class ELFT> void ObjFile<ELFT>::parse(bool isBitcodeFile) {
// Read a section table. justSymbols is usually false.
----------------
Perhaps this would better be names something like `isLTOOutput`? Otherwise it sounds like it might a bitcode object which is a different class here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80765/new/
https://reviews.llvm.org/D80765
More information about the llvm-commits
mailing list