[PATCH] D80765: [lld] Handle bitcode comdat groups separately to deduplicate thinlto comdat sections

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

(I'm probably not the right person to do detailed/semantic review of this, but here's some basic things I spotted)



================
Comment at: lld/ELF/InputFiles.cpp:610
 
-      bool isNew =
-          ignoreComdats ||
-          symtab->comdatGroups.try_emplace(CachedHashStringRef(signature), this)
-              .second;
+      // If this is a bitcode file, ignore already proceed comdat groups.
+      // Else, check all comdat groups.
----------------
typo? ("proceed" was intended to be "processed", perhaps?)


================
Comment at: lld/ELF/InputFiles.cpp:1569-1572
+  for (StringRef s : obj->getComdatTable()) {
     keptComdats.push_back(
         symtab->comdatGroups.try_emplace(CachedHashStringRef(s), this).second);
+  }
----------------
Unrelated change in this patch - probably best to remove it or commit it separately?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80765/new/

https://reviews.llvm.org/D80765