[PATCH] D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable

[Peter Klausler via Phabricator via llvm-commits]

klausler added a comment.

In D79507#2055514 <https://reviews.llvm.org/D79507#2055514>, @DavidTruby wrote:

> The runtime behaviour when compiled with RELEASE is undefined. As I and @hfinkel mentioned, the point of that is optimisations that cannot otherwise be made by the compiler. I would say that runtime performance of release builds should be one of our main priorities...


Release builds of the compiler must have well-defined behavior, and that behavior must be to crash on a fatal internal error rather than to silently proceed to generate incorrect code, which is the worst thing a compiler can do to a user.  Trading off protection against silent generation of bad code to gain some unmeasured performance improvement would be insanely irresponsible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79507/new/

https://reviews.llvm.org/D79507