[PATCH] D80609: [MLIR] expose applyCmpPredicate

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 14:18:26 PDT 2020


stephenneuendorffer added a comment.

In D80609#2057374 <https://reviews.llvm.org/D80609#2057374>, @ftynse wrote:

> Would it make sense to put them in the relevant Ops so as not to pollute the `mlir::` namespace?


Maybe...  I think if the standard dialect had a namespace they would logically go there.  (Maybe it should?)
They are more tied to the Predicate than do the comparison itself, but since it's an enum class it can't have methods.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80609/new/

https://reviews.llvm.org/D80609





More information about the llvm-commits mailing list