[PATCH] D80596: New intrinsic @llvm.get.active.lane.mask()

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/docs/LangRef.rst:16396
+Both operands have the same scalar integer type. The result is a vector with
+the i1 element type. The arguments are scalar types to accomodate scalable
+vector types, for which it is unknown what the the type of the step vector
----------------
The "to accomodate scalable vectors" etc. belongs in the paragraph describing the intended use-case, I think.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1298
+def int_get_active_lane_mask:
+  Intrinsic<[llvm_anyvector_ty],
+            [llvm_anyint_ty, LLVMMatchType<1>],
----------------
We probably want a verifier check that the result is actually an i1 vector, since we can't express that in TableGen.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80596/new/

https://reviews.llvm.org/D80596