[PATCH] D80599: [HWASan] Add sizeof(global) in report even if symbols missing.

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked 8 inline comments as done.
hctim added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_globals.h:24-32
+  // Disallow all constructors here, this object should only ever be casted
+  // over the global in the ELF PT_NOTE (in order for `addr()` to work
+  // correctly).
+  hwasan_global() = delete;
+  ~hwasan_global() = delete;
+  explicit hwasan_global(const hwasan_global &) = delete;
+  explicit hwasan_global(const hwasan_global &&) = delete;
----------------
pcc wrote:
> I wouldn't add this stuff, this type of error is pretty unlikely and would be caught in code review.
Done - but left the comment at the top of the class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80599/new/

https://reviews.llvm.org/D80599