[PATCH] D80368: Remove GlobalValue::getAlignment().

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 11:35:02 PDT 2020


efriedma marked an inline comment as done.
efriedma added inline comments.


================
Comment at: llvm/lib/LTO/LTOModule.cpp:418
   // set alignment part log2() can have rounding errors
-  uint32_t align = def->getAlignment();
+  uint32_t align = 0;
+  const GlobalObject *go = dyn_cast<GlobalObject>(def);
----------------
jdoerfert wrote:
> Isn't 1 the right choice here?
I don't think the difference between 1 and 0 has any practical effect, the way the code is currently written.  I guess I can clean this up to use Align, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80368/new/

https://reviews.llvm.org/D80368





More information about the llvm-commits mailing list