[PATCH] D80729: AMDGPU: Add IntrWillReturn to intrinsic definitions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:188
    llvm_i32_ty],      // bit offset of the thread count
-  [IntrConvergent, ImmArg<ArgIndex<1>>]>;
+  [IntrConvergent, ImmArg<ArgIndex<1>>, IntrWillReturn]>;
 
----------------
rampitec wrote:
> arsenm wrote:
> > rampitec wrote:
> > > I am not sure this one always will return. With zero input it is a kill.
> > I would expect a shader to never be launched with 0 input? I think it's also not clear if kill is really a return
> I do not really know if someone may use it this way or not. Is it important to mark it?
Marek says it wouldn't be called with 0


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80729/new/

https://reviews.llvm.org/D80729