[PATCH] D80728: [mlir][Linalg][Vector] Add forwarding patterns between linalg.copy and vector.transfer

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 11:33:25 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp:162
+
+namespace mlir {
+/// In the future this will evolve to use interfaces, side-effect modeling and
----------------
I don't think this namespace is necessary.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp:184
+        return failure();
+      else
+        subViewOp = newSubViewOp;
----------------
nit: Drop else after return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80728/new/

https://reviews.llvm.org/D80728





More information about the llvm-commits mailing list