[PATCH] D80674: Default to generating statepoints with deopt and gc-transition bundles if needed

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 10:23:49 PDT 2020


reames added a comment.

In D80674#2059761 <https://reviews.llvm.org/D80674#2059761>, @dantrushin wrote:

> LGTM with two notes:
>
> - Does it makes sense to make GCArgs `Optional<>` too? Implementation might change later, but you won't need to change interface again.


At the moment, no.  Or more accurately, I haven't thought about it enough yet to be comfortable revising the interface.  We can always revise later if needed.

> - Now that Deopt and Transition args are `Optional<>`, do we need such many `CreageGCStatepointCall` variants?

Good question, I'll take a separate look at this and maybe clean up some of them if it makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80674/new/

https://reviews.llvm.org/D80674





More information about the llvm-commits mailing list