[PATCH] D80477: [LoopUnroll] Support loops with exiting block that is neither header nor latch.

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:309
+  // (1) single latch; and
+  // (2a) latch is an exiting block; or
+  // (2b) latch is unconditional and there exists a single exiting block.
----------------
Whitney wrote:
> fhahn wrote:
> > I think for 2) it should be sufficient to state that we require a single exiting block. Unless I am missing something, that also implies that the latch must either be unconditional or the exiting block.
> When the single loop latch is an exiting block, the loop is allowed to have multiple exiting blocks. This is the original behaviour.
> 
oh right, I thought we where restricting it to single exiting block earlier on, but it is indeed not the case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80477/new/

https://reviews.llvm.org/D80477