[PATCH] D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM with minor nits.



================
Comment at: llvm/lib/MC/MCDisassembler/MCDisassembler.cpp:90
+  if (StorageMappingClass.hasValue() != SymInfo.StorageMappingClass.hasValue())
+    return  SymInfo.StorageMappingClass.hasValue();
+  
----------------
Minor nit: There's two spaces here; should only have one.


================
Comment at: llvm/lib/MC/MCDisassembler/MCDisassembler.cpp:91
+    return  SymInfo.StorageMappingClass.hasValue();
+  
+  if (StorageMappingClass.hasValue()) {
----------------
There's trailing whitespace at the end of the line here.


================
Comment at: llvm/unittests/MC/MCDisassemblerTest.cpp:33
+
+  // Test symbol with a TC0 StorageMappingClass have lower priority that those
+  // with other StorageMappingClass.
----------------
s/Test symbol/Test that symbols/;
s/that those/than those/;


================
Comment at: llvm/unittests/MC/MCDisassemblerTest.cpp:34
+  // Test symbol with a TC0 StorageMappingClass have lower priority that those
+  // with other StorageMappingClass.
+  EXPECT_TRUE(SIT5 < SIT6);
----------------
s/other/some other/;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78387/new/

https://reviews.llvm.org/D78387