[PATCH] D80662: [LiveDebugValues] Add cutoffs to avoid pathological behavior

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM, definitely better to bail out than to try something impossible.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1769
+
+  if (RPONumber > InputBBLimit) {
+    unsigned NumInputDbgValues = 0;
----------------
Iterating over all instructions again is probably unfortunate for performance -- it could be counted on line 1744 of this patch?

On the other hand, given the exceptional circumstances that this will trigger in, that's not really a concern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80662/new/

https://reviews.llvm.org/D80662