[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

Balogh, Ádám via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 07:02:32 PDT 2020


baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added a comment.

> I will check tomorrow whether we could remove `DeclRegion` without too much code duplication.

It turns out that `DeclRegion` is used in 7 different checkers plus in `BugReporterVisitor`s. One typical use case is to get a name for the region (by getting the `Decl` and trying to cast it to `NamedDecl`), but there are also others as well. For now I suggest to keep it to avoid code duplication.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80522/new/

https://reviews.llvm.org/D80522





More information about the llvm-commits mailing list