[PATCH] D80705: [MLIR] Add TensorFromElementsOp to Standard ops.

Stephan Herhut via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 06:30:25 PDT 2020


herhut accepted this revision.
herhut added a comment.
This revision is now accepted and ready to land.

Thanks.



================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:1556
+    }]>];
+
+  let hasCanonicalizer = 1;
----------------
pifon2a wrote:
> herhut wrote:
> > Would `let assemblyFormat = "`(` $elements `)` attr-dict `:` type($result)";` work?
> no, it wouldn't. It would need to know the elements type to parse it. Can I use assemblyFormat for printing only and a custom parser?
Answer is, it does not because the operand types cannot be deduced with the given traits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80705/new/

https://reviews.llvm.org/D80705





More information about the llvm-commits mailing list