[PATCH] D79936: [FileCheck] Add function call support to numerical expressions.
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 28 05:57:27 PDT 2020
arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.
LGTM if @thopre and @jhenderson are happy with this change too.
================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:784
+ Tester.parseSubst("!(FOO)").takeError());
+ expectDiagnosticError("missing argument",
+ Tester.parseSubst("!mul(FOO,)").takeError());
----------------
Might make sense to add case with missing operators such as `2!mul(FOO,2)` or `FOO !mul(FOO,2)` or `!mul(FOO(!mul(3,2)))`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79936/new/
https://reviews.llvm.org/D79936
More information about the llvm-commits
mailing list