[PATCH] D80683: [SelectionDAG] Fix up SimplifyDemandedBits for ppcf128
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 28 05:23:54 PDT 2020
RKSimon requested changes to this revision.
RKSimon added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:855
+ !TLO.BitsRotatedForPPCF128) {
+ TLO.BitsRotatedForPPCF128 = true;
+ DemandedBits = DemandedBits.rotl(64);
----------------
This is going to have the issue that it doesn't reset the flag to its old state when you leave the function, and TLO by design needs to be passed by reference.
Initially we might just have to bailout if we encounter MVT::ppcf128 until we can come up with a better solution?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80683/new/
https://reviews.llvm.org/D80683
More information about the llvm-commits
mailing list